Return with exit-code 1 when having an error (LP: #2104373)#565
Open
Cellebyte wants to merge 1 commit intocanonical:mainfrom
Open
Return with exit-code 1 when having an error (LP: #2104373)#565Cellebyte wants to merge 1 commit intocanonical:mainfrom
Cellebyte wants to merge 1 commit intocanonical:mainfrom
Conversation
Cellebyte
force-pushed
the
fix/return-code
branch
7 times, most recently
from
1ea934a to
9d35107
Compare
Cellebyte
force-pushed
the
fix/return-code
branch
from
9d35107 to
250ce2b
Compare
Contributor
Author
|
@slyon is this a breaking API change? |
5 tasks
Collaborator
|
Thanks for the update on this. Sorry for not getting to this earlier -- there's been a number of staffing changes here and we're coming up to speed on netplan. We hope to review this properly (with context) in the next couple of weeks, but at first look (and the LP issue) it looks reasonable. |
benhoyt
added
the
needs review soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the successor of https://github.com/canonical/netplan/pull/551/changes.
Checklist
make checksuccessfully.make check-coverage).