-
Notifications
You must be signed in to change notification settings - Fork 6
test: add version test module #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
medubelko
wants to merge
4
commits into
main
Choose a base branch
from
work/add-version-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+52
−4
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # This file is part of starcraft. | ||
| # | ||
| # Copyright 2026 Canonical Ltd. | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify it | ||
| # under the terms of the GNU General Public License version 3, as published | ||
| # by the Free Software Foundation. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, but WITHOUT | ||
| # ANY WARRANTY; without even the implied warranties of MERCHANTABILITY, | ||
| # SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| # General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License along | ||
| # with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| """Basic tests for Starbase version attributes.""" | ||
|
|
||
| import re | ||
|
|
||
| import pytest | ||
| import starcraft | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def get_major_minor_version(): | ||
| """Fixture method that duplicates version trimming in docs/conf.py.""" | ||
|
|
||
|
medubelko marked this conversation as resolved.
|
||
| def _trim(version): | ||
| expression = re.compile(r"\d+\.\d+") | ||
|
medubelko marked this conversation as resolved.
Outdated
|
||
|
|
||
| return expression.match(version).group() | ||
|
|
||
|
medubelko marked this conversation as resolved.
Outdated
|
||
| return _trim | ||
|
|
||
|
|
||
| def test_version(): | ||
| """Test that the version attribute is generating.""" | ||
|
medubelko marked this conversation as resolved.
|
||
| assert starcraft.__version__ is not None | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "version,major_minor", # NOQA: PT006 | ||
|
medubelko marked this conversation as resolved.
Outdated
medubelko marked this conversation as resolved.
Outdated
|
||
| [ | ||
| ("9.0.0", "9.0"), # Tagged | ||
| ("9.0.0-23-gc2a9d6349", "9.0"), # Tagged + new commits | ||
|
medubelko marked this conversation as resolved.
|
||
| ("0.0.post836+g494e37055.d20260612", "0.0"), # Untagged | ||
| ], | ||
| ) | ||
| def test_version_tagged(version, major_minor, get_major_minor_version): | ||
|
medubelko marked this conversation as resolved.
Outdated
|
||
| """Test the version-to-major-minor function.""" | ||
| assert get_major_minor_version(version) == major_minor | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.