SV Weights on Ledger PoC - #24
Open
akonior wants to merge 24 commits into
Open
Conversation
Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
… to old Scala tests, fixed daml comment indentation issues. Signed-off-by: Przemysław Pawelec <przemyslaw.pawelec@intellecteu.com>
Signed-off-by: Przemysław Pawelec <przemyslaw.pawelec@intellecteu.com>
Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
akonior
force-pushed
the
sv-weights-poc2
branch
from
August 27, 2026 20:41
106803f to
04d431a
Compare
akonior
marked this pull request as ready for review
August 28, 2026 09:32
Signed-off-by: Przemysław Pawelec <przemyslaw.pawelec@intellecteu.com>
Signed-off-by: Przemysław Pawelec <przemyslaw.pawelec@intellecteu.com>
Signed-off-by: Przemysław Pawelec <przemyslaw.pawelec@intellecteu.com>
CI is back to green - daml version bump, typescript code regenerated, Scalafmt applied.
Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
No behaviour change: rename `SvRightOwnerInfo.party` to `rightOwnerParty`, replace the `foldMap`/`Sum` reward-weight sums with `sum`, document the 20 beneficiary limit, and drop the TODOs the reviewer asked to remove. Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
The choices documented their `openMiningRoundCid` as the latest open round but checked nothing, so a caller could anchor a new SV right owner to a round its SV node operator had already minted for. `validateOpenMiningRoundTriple` derives the latest usable round from the three open rounds instead. Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
`SvRewardState` is keyed by SV name, so archiving all of them at migration reset `lastRoundCollected` and the coupon counters for every SV that keeps its name. Reuse the existing state in that case and archive only the rest. [ci] Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
[ci] Signed-off-by: Arkadiusz Konior <arkadiusz.konior@intellecteu.com>
…iew-comments Review comments fixes [ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.