Add balances to ACS snapshots - #2318
Conversation
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
meiersi-da
left a comment
There was a problem hiding this comment.
Nice work! Computing it jointly with the snapshot sounds great. Best chance to share the work.
moritzkiefer-da
left a comment
There was a problem hiding this comment.
nice! Query plans and some timings on CILR would be great
|
Here's a regular explain while I fail to run the analyze on cloudsql: https://www.pgexplain.dev/plan/f4527fda-e660-4941-840a-9f1f167cac21 |
|
And here with explain analyze buffers:
^This part was pre-existing.
^For this:
|
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
moritzkiefer-da
left a comment
There was a problem hiding this comment.
nice lgtm! Should we extend the update plugin at the end of the test to check that the balance updates are identical? Thinking about this again, I guess you're not actually exposing it over endpoints yet so this would be a follow up.
|
@moritzkiefer-da implemented in the last commit in #2334 |
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>


Part of #2254