Skip to content

Add scalatest tags for daml compatibility checks - #3797

Merged
dfordivam merged 2 commits into
mainfrom
dfordivam/fix-daml-compat-integ2
Feb 3, 2026
Merged

Add scalatest tags for daml compatibility checks#3797
dfordivam merged 2 commits into
mainfrom
dfordivam/fix-daml-compat-integ2

Conversation

@dfordivam

@dfordivam dfordivam commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #3793

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@dfordivam
dfordivam requested a review from isegall-da February 3, 2026 03:01
Signed-off-by: Divam <dfordivam@gmail.com>
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
dfordivam force-pushed the dfordivam/fix-daml-compat-integ2 branch from d9bf27a to be51a13 Compare February 3, 2026 03:12
@dfordivam

Copy link
Copy Markdown
Contributor Author

I ran the build.yaml workflow against the 0.5.8 version. It had one failure which is unrelated to my changes.

https://github.com/hyperledger-labs/splice/actions/runs/21617369462

 [info] - should show notification transactions *** FAILED ***
[info]   Unable to find notifiation transaction row (WalletTransactionHistoryFrontendIntegrationTest.scala:371)

@martinflorian-da martinflorian-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dfordivam
dfordivam merged commit c706392 into main Feb 3, 2026
117 of 118 checks passed
@dfordivam
dfordivam deleted the dfordivam/fix-daml-compat-integ2 branch February 3, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beneficiary tests fail daml_compat_tests

2 participants