Add fund manager blacklist and dev fund coupon mint delay - #6793
Merged
meiersi-da merged 13 commits intoAug 21, 2026
Merged
Conversation
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
6 times, most recently
from
August 18, 2026 09:32
3af23fe to
a566646
Compare
zheli
marked this pull request as ready for review
August 18, 2026 09:44
meiersi-da
reviewed
Aug 18, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Thanks a lot!
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
5 times, most recently
from
August 19, 2026 11:51
7fe91ac to
983289f
Compare
meiersi-da
reviewed
Aug 19, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for the good work and quick turnaround time. Two issues remain before we are ready:
- add release notes (as explained on Slack)
- address the
ExternalPartyConfigStatecode path concern
…gDelay to AmuletConfig Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
… UI to deal with the merging. Revert changes in Splice.Util Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
…ngDelay and mintAfter Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
…y to scala integration tests and utility classes Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
from
August 20, 2026 10:03
983289f to
e1b972f
Compare
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
from
August 20, 2026 10:46
081c1c1 to
0d10d57
Compare
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
from
August 20, 2026 10:50
0d10d57 to
5e02f41
Compare
Author
Thanks for your comments @meiersi-da ! Just fixed all the feedback and pushed the change. Could you check them again? |
meiersi-da
approved these changes
Aug 20, 2026
meiersi-da
left a comment
meiersi-da
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the good work.
Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
from
August 20, 2026 14:33
5e02f41 to
76ae22a
Compare
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
from
August 20, 2026 15:46
27c8455 to
6f73b13
Compare
…pmentFundMintingDelay in frontend Signed-off-by: Zhe Li <linuxcity.jn@gmail.com>
zheli
force-pushed
the
zheli/delay-devfund-coupon-collection/6722
branch
from
August 20, 2026 18:51
6f73b13 to
60b4574
Compare
meiersi-da
reviewed
Aug 21, 2026
| externalPartyConfigStateTickDuration: null, | ||
| rewardConfig: null, | ||
| transferPreapprovalBaseDuration: null, | ||
| developmentFundManagerBlacklist: null, |
Contributor
There was a problem hiding this comment.
please don't forget to create tests for the UI to change this value, given that it has a non-standard type: list of parties.
It's fine to do though in a follow-up ticket.
Author
There was a problem hiding this comment.
Ticket is created: #6904, I will include them in the UI changes.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #6722