Skip to content

Helm charts hardening: don't mount k8s API tokens by default #7017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinflorian-da wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Helm charts hardening: don't mount k8s API tokens by default #7017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cluster/helm/cn-docs/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"networkName": {
"type": "string"
},
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-cometbft/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"genesis": {
"type": "object",
"required": [
Expand Down
6 changes: 6 additions & 0 deletions cluster/helm/splice-domain/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"securityContexts": {
"type": ["object", "null"],
"properties": {
Expand Down
6 changes: 6 additions & 0 deletions cluster/helm/splice-global-domain/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"securityContexts": {
"type": "object",
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-info/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"nginxImage": {
"type": "string",
"description": "The Docker image to use for Nginx. Defaults to 'nginx:latest' if not present."
Expand Down
6 changes: 6 additions & 0 deletions cluster/helm/splice-load-tester/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"securityContexts": {
"type": ["object", "null"],
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-participant/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"imageRepo": {
"type": "string"
},
Expand Down
6 changes: 6 additions & 0 deletions cluster/helm/splice-party-allocator/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"securityContexts": {
"type": ["object", "null"],
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-postgres/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"imageRepo": {
"type": "string"
},
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-scan/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"imageRepo": {
"type": "string"
},
Expand Down
6 changes: 6 additions & 0 deletions cluster/helm/splice-splitwell-app/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"securityContexts": {
"type": ["object", "null"],
"properties": {
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-splitwell-web-ui/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"imageName": {
"type": "string"
},
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-sv-node/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"imageName": {
"type": "string"
},
Expand Down
5 changes: 3 additions & 2 deletions cluster/helm/splice-util-lib/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,10 @@ spec:
value: {{ .logAsyncFlush | default true | not | quote }}
{{- end }}
{{- define "splice-util-lib.service-account" -}}
{{- if .serviceAccountName -}}
automountServiceAccountToken: {{ .automountServiceAccountToken | default false }}
{{- if .serviceAccountName }}
serviceAccountName: {{ .serviceAccountName }}
{{- end -}}
{{- end }}
{{- end -}}
# See https://helm.sh/docs/chart_best_practices/labels/#standard-labels
{{- define "splice-util-lib.standard-labels" -}}
Expand Down
3 changes: 3 additions & 0 deletions cluster/helm/splice-validator/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@
"serviceAccountName": {
"type": "string"
},
"automountServiceAccountToken": {
"type": "boolean"
},
"ansWebUi": {
"type": "object",
"required": ["imageName"],
Expand Down
10 changes: 10 additions & 0 deletions docs/src/release_notes_upcoming.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@

release-notes:: Upcoming

- Deployment

- All Splice Helm charts now set ``automountServiceAccountToken: false`` on the pods they
deploy. Splice components do not use the Kubernetes API, so pods no longer receive an
API-server credential by default; this reduces the impact of a compromised pod in
clusters where permissions are bound to the namespace's ``default`` service account.
If your deployment relies on the mounted token, for example through a custom service
account set via ``serviceAccountName``, you can restore the previous behavior by setting
the new ``automountServiceAccountToken`` Helm value to ``true``.

- SV App

- The public ``/v0/dso`` endpoint is deprecated and will be removed in 0.9.0
Expand Down
Loading