Skip to content

docs: update plugin doc #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rukmini-basu-da wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: update plugin doc #2362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/wallet-integration-guide/examples/snippets/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
},
ledgerClientUrl: 'http://localhost:2975',
})
).registerPlugins({
myPlugin: class extends SDKPlugin {
).registerPlugins([
class extends SDKPlugin {
// wallet-sdk plugin should always accept SDKPluginContext
constructor(protected readonly ctx: SDKPluginContext) {
super('myPlugin', ctx)
Expand All @@ -27,7 +27,7 @@
return
}
},
})
])

sdk.myPlugin.myMethod()

Check failure on line 32 in docs/wallet-integration-guide/examples/snippets/plugin.ts

View workflow job for this annotation

GitHub Actions / wallet-sdk-snippets-e2e (mainnet)

snippets.test.ts > testing doc snippets > plugin.ts 

TypeError: Cannot read properties of undefined (reading 'myMethod')
 ❯ snippets/plugin.ts:32:18
 ❯ snippets.test.ts:23:32

Check failure on line 32 in docs/wallet-integration-guide/examples/snippets/plugin.ts

View workflow job for this annotation

GitHub Actions / wallet-sdk-snippets-e2e (devnet)

snippets.test.ts > testing doc snippets > plugin.ts 

TypeError: Cannot read properties of undefined (reading 'myMethod')
 ❯ snippets/plugin.ts:32:18
 ❯ snippets.test.ts:23:32
}
Loading