fix(wallet-gateway-remote): include sign-message and api-keys pages i… - #2368
Open
gjrmacedo wants to merge 1 commit into
Open
fix(wallet-gateway-remote): include sign-message and api-keys pages i…#2368gjrmacedo wants to merge 1 commit into
gjrmacedo wants to merge 1 commit into
Conversation
…n build Signed-off-by: gjrmacedo <gjrmacedo@gmail.com>
gjrmacedo
force-pushed
the
fix/include-sign-message-and-api-keys-in-build
branch
from
August 26, 2026 22:14
9a25b85 to
a17ed69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three pages exist under
wallet-gateway/remote/src/web/frontend/and are declared asvalid routes in
ALLOWED_ROUTES(core/wallet-ui-components/src/routing.ts), but aremissing from the Vite multi-page
rollupOptions.input, so they are never emitted:sign-message/api-keys/api-keys/add/The source tree has 18
index.htmlentry points; the build config lists 15.User-visible impact:
signMessageis unreachable over the dApp APIwallet-gateway/remote/src/dapp-api/controller.tsreturnsand
@canton-network/dapp-sdkopens that URL in a popup. Because the page is not in thebuild output, the popup lands on a 404 and the signing request can never be approved —
signMessagetimes out for every dApp using a remote Wallet Gateway.Reproduced against the published artifact, not just the source tree: the
@canton-network/wallet-gateway-remote@1.9.0tarball (the exact package installed byghcr.io/digital-asset/wallet-gateway/docker/wallet-gateway) contains nodist/web/frontend/sign-message/directory, and no chunk indist/web/frontend/assets/references
user-ui-sign-messageorgetMessageToSign. The gateway serves that directorywith a plain
express.static(), so a missing entry point is an unconditional 404.How it got missed
sign-message/was added in #1718 (2026-05-18), which wired up the dApp API, the RPCmethods and the Lit component (with unit tests), but did not touch
wallet-gateway/remote/vite.config.ts— a file unchanged since #1520 (2026-03-31).This is the same class of regression already fixed once in #1045
("fix: include transactions page in build").
Fix
Add the three missing entry points to
rollupOptions.input, grouped next to theirsiblings (
signMessagebesideapprove;apiKeys/addApiKeybesidesettings,following the existing
parties/addPartyandnetworks/addNetworkpattern).Verification
vite buildinwallet-gateway/remotenow emits 18 pages, matching the 18 entry pointsin the source tree (15 before):
Notes
(
sign-message/index.test.ts,api-keys/index.test.ts,api-keys/add/index.test.ts)already pass; they were simply testing components that never shipped.
src/web/frontend/that is missing fromrollupOptions.inputfails CI — this is the second occurrence.