-
Notifications
You must be signed in to change notification settings - Fork 90
feat: support for App Open Ad en Android e iOS - fix comments #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
distante
merged 40 commits into
capacitor-community:main
from
yarivgdidi:app-open-ad-review-fixes
Apr 10, 2026
Merged
Changes from 33 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
4f9ea4f
rebase main
yarivgdidi ce515c3
Update src/web.ts
BETOXL 2cb85f3
Update src/web.ts
BETOXL 8a46c8a
Update demo/angular/src/app/app.component.ts
BETOXL 79654eb
Update README.md
BETOXL 540573c
Update README.md
BETOXL 8c8d6f9
Update README.md
BETOXL 544528f
Update AppOpenAdManager.java
BETOXL 538cc30
Update AppOpenAdManager.java
BETOXL cd21f66
Update AppOpenAdManager.java
BETOXL 88df068
Update AdMob.java
BETOXL cb76260
Update app.component.ts
BETOXL 4a8071e
Update AppOpenAdManager.swift
BETOXL ff7f28f
Update app-open-definitions.interface.ts
BETOXL 8be2121
Update web.ts
BETOXL 8cbc810
Update README.md
BETOXL 2377c8f
Refactor AppOpenAd Plugin initialization
BETOXL 31ac6e5
Define AppOpenAdOptions interface and update loadAppOpen
BETOXL 088fe10
Update AppOpenAdManager.java
BETOXL 13b0992
Update android/src/main/java/com/getcapacitor/community/admob/appopen…
BETOXL 0d64991
Update src/web.ts
BETOXL 2a2fc5e
Update README.md
BETOXL b42a565
Update demo/angular/src/app/app.component.ts
BETOXL 7564a9b
Update README.md
BETOXL 8ec3d1b
Update README.md
BETOXL f925ea0
Update demo/angular/src/app/app.component.ts
BETOXL c1c19ce
Fix App Open ad lifecycle, event emission, and docs across Android/iOS
yarivgdidi 9b08fdf
GoogleMobileAds fixes
yarivgdidi 066e0ff
GoogleMobileAds fixes
yarivgdidi 264d75e
GoogleMobileAds fixes
yarivgdidi e397821
GoogleMobileAds fixes
yarivgdidi 6e84322
fix: address all PR review comments
yarivgdidi b8600b2
fix: address second round of Copilot review comments
yarivgdidi e3a0b3e
fix: use events enum and bubble errors per reviewer feedback
yarivgdidi 53bbcd7
fix: address reviewer feedback - demo app and screenshots
yarivgdidi ff6eea6
fix: typed listener overloads, isAdLoaded check, remove unused factory
yarivgdidi 0e4f79b
fix: error params in README examples, remove unused rootViewController
yarivgdidi 03966b4
fix: consistency improvements from self-review
yarivgdidi 182330b
fix: restore createAppOpenOptions factory method and tests
yarivgdidi a3fe7e3
refactor: convert AppOpenAdPlugin and AppOpenAdManager from Java to K…
yarivgdidi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.