Skip to content

CS-11326: standardize sort + selection-menu triggers on CaretDown (flip on open) #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukemelia merged 1 commit into from
Jun 5, 2026
Merged

CS-11326: standardize sort + selection-menu triggers on CaretDown (flip on open) #5114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/boxel-ui/addon/src/components/selection-menu/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Component from '@glimmer/component';

import type { MenuDivider } from '../../helpers/menu-divider.ts';
import type { MenuItem } from '../../helpers/menu-item.ts';
import { DropdownArrowDown } from '../../icons.gts';
import CaretDown from '../../icons/caret-down.gts';
import BoxelButton from '../button/index.gts';
import BoxelDropdown from '../dropdown/index.gts';
import Menu from '../menu/index.gts';
Expand Down Expand Up @@ -66,7 +66,7 @@ export default class SelectionMenu extends Component<Signature> {
>
<SelectionCheckmark class='selection-menu-icon' />
<span class='selection-menu-count'>{{@selectedCount}}</span>
<DropdownArrowDown
<CaretDown
class='selection-menu-caret'
width='13px'
height='13px'
Expand Down
13 changes: 10 additions & 3 deletions packages/boxel-ui/addon/src/components/sort-dropdown/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Component from '@glimmer/component';

import { MenuDivider } from '../../helpers/menu-divider.ts';
import { MenuItem } from '../../helpers/menu-item.ts';
import DropdownIcon from '../../icons/dropdown-arrow-down.gts';
import CaretDown from '../../icons/caret-down.gts';
import BoxelButton from '../button/index.gts';
import BoxelDropdown from '../dropdown/index.gts';
import BoxelMenu from '../menu/index.gts';
Expand Down Expand Up @@ -34,7 +34,7 @@ export default class SortDropdown extends Component<Signature> {
{{bindings}}
>
{{if @selectedOption @selectedOption.displayName 'Please Select'}}
<DropdownIcon width='12px' height='12px' />
<CaretDown class='sort-button-caret' width='12px' height='12px' />
</BoxelButton>
</:trigger>
<:content as |dd|>
Expand Down Expand Up @@ -65,8 +65,15 @@ export default class SortDropdown extends Component<Signature> {
padding-left: var(--boxel-sp-sm);
padding-right: var(--boxel-sp-sm);
}
.sort-button > svg {
.sort-button-caret {
margin-left: auto;
transition: transform var(--boxel-transition);
}
/* Flip the caret while the menu is open, matching boxel-ui's
select/dropdown triggers. BoxelDropdown sets aria-expanded on the
trigger button via the yielded bindings. */
.sort-button[aria-expanded='true'] .sort-button-caret {
transform: rotate(180deg);
}
}
</style>
Expand Down
Loading