Skip to content

Allow JavaScript binding when browser wrapper cannot be found #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaitland merged 3 commits into from
Apr 10, 2026
Merged

Allow JavaScript binding when browser wrapper cannot be found #5229

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb57fa2
Allow JavaScript binding when browser wrapper cannot be found
campersau Mar 31, 2026
0e09797
Store JavascriptBindingSettings per Browser and never remove them
campersau Apr 9, 2026
9687d6c
Use dict->Values
campersau Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions CefSharp.BrowserSubprocess.Core/CefAppUnmanagedWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ namespace CefSharp

auto browserWrapper = FindBrowserWrapper(browser->GetIdentifier());

if (browserWrapper != nullptr && browserWrapper->JavascriptBindingApiEnabled && IsJavascriptBindingApiAllowed(browserWrapper, frame))
if (IsJavascriptBindingApiAllowed(browserWrapper, frame))
{
//TODO: Look at adding some sort of javascript mapping layer to reduce the code duplication
auto global = context->GetGlobal();
Expand Down Expand Up @@ -349,7 +349,17 @@ namespace CefSharp

bool CefAppUnmanagedWrapper::IsJavascriptBindingApiAllowed(CefBrowserWrapper^ browserWrapper, CefRefPtr<CefFrame> frame)
{
if (browserWrapper == nullptr || !browserWrapper->JavascriptBindingApiHasAllowOrigins)
if (browserWrapper == nullptr)
{
return true;
}

if (!browserWrapper->JavascriptBindingApiEnabled)
{
return false;
}

if (!browserWrapper->JavascriptBindingApiHasAllowOrigins)
{
return true;
}
Expand Down