Add checker conformance tests for type parameter deduction for type(t) - #529
Open
l46kok wants to merge 1 commit into
Open
Add checker conformance tests for type parameter deduction for type(t)#529l46kok wants to merge 1 commit into
l46kok wants to merge 1 commit into
Conversation
jnthntatum
reviewed
Sep 10, 2026
| test { | ||
| name: "type_map_erasure_comparison" | ||
| check_only: true | ||
| expr: "type({}) == map" |
Collaborator
There was a problem hiding this comment.
could you add explicit tests for the edge cases around free parameters?
I don't think these are super practical expressions but maybe better to document the weirdness than not?
It's also a bit of a can of worms so it might be fine to leave unspecified for now until we sort out the other issues with type unification.
I think the updates in C++ and java have us with something like:
[type([]), int] -> list(dyn)
[] + [[type(1)]] + [[type([])]] -> list<list<dyn>>
false ? int : type([]) -> no overload
Collaborator
Author
There was a problem hiding this comment.
Let me send these out as a separate PR, the [] + [[type(1)]] + [[type([])]] case especially requires further discussion (all of the stacks are divergent, so we need to decide on a behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.