feat(celo-derive): add batch-auth enforcement grace window (mirrors op-node)#240
Merged
Conversation
Contributor
|
Hey @lukeiannucci, is this ready to be reviewed now? |
Collaborator
Author
@piersy |
lukeiannucci
marked this pull request as ready for review
July 14, 2026 23:06
lukeiannucci
force-pushed
the
espresso/enforcement-window
branch
from
July 14, 2026 23:06
dfae32c to
16f87be
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfae32cdeb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
piersy
reviewed
Jul 16, 2026
piersy
reviewed
Jul 16, 2026
piersy
reviewed
Jul 16, 2026
piersy
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors PR found celo-org/optimism#468
During the grace window [EspressoTime, EspressoTime + BatchAuthEnforcementDelaySecs), derivation keeps accepting sender-authenticated batches exactly as pre-fork this absorbs the skew between when the batcher decides a batch (L1 tip time) and when it lands (containing-block time), which the lead time previously compensated for. The batcher now switches to authenticated submission at plain activation (IsEspresso(l1Tip.Time)) with no configuration. By the time enforcement begins its auth events have been accumulating for a full lookback window, so the first enforced scan is fully populated.