op-deployer: update drifted Sepolia SuperchainConfigImpl in reuse test#473
Closed
karlb wants to merge 1 commit into
Closed
op-deployer: update drifted Sepolia SuperchainConfigImpl in reuse test#473karlb wants to merge 1 commit into
karlb wants to merge 1 commit into
Conversation
TestInitLiveStrategy_OPCMReuseLogicSepolia forks live Sepolia and asserts the standard superchain's on-chain SuperchainConfig implementation against a hardcoded address. That proxy's implementation was upgraded on Sepolia since the constant was last set, so the "embedded L1 locator with standard intent types and standard roles" subtest fails with: expected SuperchainConfigImpl 0xb08Cc720...a957 actual SuperchainConfigImpl 0xE4F9779a...D550 The new value is what the forked-Sepolia read returned in CI (i.e. the current live implementation), so update the constant to match. Only this subtest is affected; the other assertions read a different, older superchain and are unchanged. Note: this assertion is inherently drift-prone and will break again on the next Sepolia SuperchainConfig upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this test make sense for us? Should we keep updating it like this after every change or should we disable the test?
TestInitLiveStrategy_OPCMReuseLogicSepolia forks live Sepolia and asserts the standard superchain's on-chain SuperchainConfig implementation against a hardcoded address. That proxy's implementation was upgraded on Sepolia since the constant was last set, so the "embedded L1 locator with standard intent types and standard roles" subtest fails with:
expected SuperchainConfigImpl 0xb08Cc720...a957
actual SuperchainConfigImpl 0xE4F9779a...D550
The new value is what the forked-Sepolia read returned in CI (i.e. the current live implementation), so update the constant to match. Only this subtest is affected; the other assertions read a different, older superchain and are unchanged.
Note: this assertion is inherently drift-prone and will break again on the next Sepolia SuperchainConfig upgrade.