Fix array return types for tuples of arrays - #29241
Open
jabraham17 wants to merge 11 commits into
Open
Conversation
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
force-pushed
the
fix-array-return
branch
from
August 12, 2026 16:39
1b9c516 to
7c25d41
Compare
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
marked this pull request as ready for review
August 14, 2026 16:36
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
benharsh
approved these changes
Aug 14, 2026
benharsh
left a comment
benharsh
left a comment
Member
There was a problem hiding this comment.
Looks good! Just one note about a new error message.
| auto retCall = toCallExpr(retExpr); | ||
| if (typeCall && typeCall->isNamed("_build_tuple")) { | ||
| if (!(retCall && retCall->isNamed("_build_tuple"))) { | ||
| USR_FATAL(fn, "return type is a tuple, but return value is not"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where explicit return types of a tuple of arrays (either anonymous domains or generic return types) would fail with obscure errors
fixes #29235
I ended up fixing several other issues while here
[]not being checked to be an array[] int(unknown domain)[D](unknown type)I also found #29261 and filed futures for it
[Reviewed by @]