Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Fixing one more case that slipped past me... sigh - #18

Merged
bradcray merged 1 commit into
chapel-lang:masterfrom
bradcray:one-more-fix-bang-bang-bang
Sep 4, 2020
Merged

Fixing one more case that slipped past me... sigh#18
bradcray merged 1 commit into
chapel-lang:masterfrom
bradcray:one-more-fix-bang-bang-bang

Conversation

@bradcray

@bradcray bradcray commented Sep 4, 2020

Copy link
Copy Markdown
Member

No description provided.

@bradcray

bradcray commented Sep 4, 2020

Copy link
Copy Markdown
Member Author

@ronawho, @ben-albrecht, @gbtitus: This is trivial, but I'd never put it past myself to screw up a trivial Python change.

@ronawho

ronawho commented Sep 4, 2020

Copy link
Copy Markdown

Do we know why Travis-CI is failing? If it was passing would that give us more confidence in these changes (I haven't looked at the failure or what the CI tests yet myself)

@bradcray

bradcray commented Sep 4, 2020

Copy link
Copy Markdown
Member Author

I tried to fix travis-ci when I was doing the first round of changes last month and PR #14 was part of my attempt at getting started with it. My sense was that it was all related to changes in pip package names and Python2 vs. 3 issues, but it felt like whenever I got it working in one environment (e.g., my desktop, Travis, the actual Heroku setting), it would break in another, probably due to my lack of skills. I'm not sure whether it would catch these issues or not, but knowing Thomas, probably?

@bradcray
bradcray merged commit 23bd216 into chapel-lang:master Sep 4, 2020
@bradcray
bradcray deleted the one-more-fix-bang-bang-bang branch September 4, 2020 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants