Skip to content

Allow setting redis options - #108

Merged
krzyzak merged 1 commit into
bump-gush-dependenciesfrom
update-redis-configuration
Feb 29, 2024
Merged

Allow setting redis options#108
krzyzak merged 1 commit into
bump-gush-dependenciesfrom
update-redis-configuration

Conversation

@krzyzak

@krzyzak krzyzak commented Feb 28, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@krzyzak
krzyzak merged commit ac941a2 into bump-gush-dependencies Feb 29, 2024
@wnm

wnm commented Jun 18, 2024

Copy link
Copy Markdown

I think this was maybe merged into the wrong branch and eventually didn't land in 3.0.0 @krzyzak, as discussed in #102?

@wnm

wnm commented Jun 26, 2024

Copy link
Copy Markdown

Could you take a look @krzyzak please? 😇

@wnm

wnm commented Aug 12, 2025

Copy link
Copy Markdown

I believe this was merged into the wrong branch.

gush 4.2.0 still gives me the same error:

NoMethodError: undefined method 'redis=' for an instance of Gush::Configuration (NoMethodError)

    config.redis = { url: Settings.redis.url }

@wnm

wnm commented Aug 12, 2025

Copy link
Copy Markdown

could we reopen this @krzyzak

@krzyzak

krzyzak commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator Author

@wnm you're right, my bad 🤦. Can you create a PR that handles that? I'm happy to merge it!

@wnm

wnm commented Aug 13, 2025

Copy link
Copy Markdown

@wnm you're right, my bad 🤦. Can you create a PR that handles that? I'm happy to merge it!

#132

@wnm

wnm commented Sep 1, 2025

Copy link
Copy Markdown

@wnm you're right, my bad 🤦. Can you create a PR that handles that? I'm happy to merge it!

@krzyzak can you take a look at #132 please?

@wnm

wnm commented Sep 24, 2025

Copy link
Copy Markdown

@krzyzak I created a PR as you asked. Could you merge it and relase a new version please 😇 #132

@wnm

wnm commented May 27, 2026

Copy link
Copy Markdown

@krzyzak PR created, can you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants