fix: create_send_msg_jobs: Don't pass message ID to smtp when resending to new broadcast members#8155
Open
fix: create_send_msg_jobs: Don't pass message ID to smtp when resending to new broadcast members#8155
smtp when resending to new broadcast members#8155Conversation
iequidoo
changed the title
smtp
Follow-up to 970222f. When resending to new broadcast members, we shouldn't update the message db entry and also share the message id with existing SMTP jobs: - Otherwise the behavior would depend on timings which isn't good. - If the message sending failed, resending it to a new member shalln't make it `OutDelivered`.
iequidoo
force-pushed
the
iequidoo/fix-races-with-resending
branch
from
0571c55 to
0845850
Compare
iequidoo
changed the title
smtpsmtp when resending to new broadcast members
Collaborator
Author
|
Not clear if this should be added to https://github.com/orgs/deltachat/projects/92/views/1 because we should "get channels out of experimental" and this fixes a regression in channels, but it seems to only happen in a fail scenario. Cc @r10s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 970222f. When resending to new broadcast members, we shouldn't update the message db
entry and also share the message id with existing SMTP jobs:
OutDelivered.TODO: Update commit message.