Conversation
link2xt
reviewed
Apr 6, 2026
link2xt
reviewed
Apr 6, 2026
j4n
approved these changes
Apr 7, 2026
…to be there, proper unbound on ipv4)
…licitely falling back to a "chatmail.ini" in parent dirs
link2xt
approved these changes
Apr 8, 2026
| """Run local and online tests for chatmail deployment.""" | ||
|
|
||
| env = os.environ.copy() | ||
| env["CHATMAIL_INI"] = str(args.inipath.absolute()) |
Contributor
There was a problem hiding this comment.
I don't fully understand what "make "cmdeploy test --config ..." work, without requiring or implicitely falling back to a "chatmail.ini" in parent dirs" means. Looks like --config was never required and the bug was that its value was not passed into pytest. That's also why this is only in the test subcommand.
Contributor
Author
There was a problem hiding this comment.
it was meant to say that a chatmail.ini (in parent dirs of a test) was required despite "cmdeploy test --config" specifying one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minimizes and supersedes #907 #884 which added "cmdeploy lxc-*" subcommands but also added a lot of code that we don't really want in the cmdeploy repository. Instead i am working on a new "cmlxc" command (work title) that lives in a separate repository. It will run tests inside a container which has access to local DNS resolution (the same PowerDNS setup as in the superseded PRs), so no dns-over-ssh resultion is needed anymore, further simplifying the PR.It now focuses on a few neccessary fixes and enhancements, that can be independently merged and are useful fixes and improvements by themselves, even without any lxc:
fix: make "cmdeploy test --config ..." work, without requiring or implicitely falling back to a "chatmail.ini" in parent dirs
refactor: unify DNS zone-file to standard BIND format
feat: update chatmail-turn to support private addresses
refactor: various deployer improvements (VM detection, mailboxes dir ensured to be there, proper unbound on ipv4)
fix: properly terminate and wait on subprocesses on test teardown
For those concerned, LLM tooling was involved in pulling code out and refining some parts. All LOCs were manually reviewed and edited.