Fix EventDateTime cast failing on date properties#52
Merged
Conversation
EventDateTime's doorsOpen, start and end carry #[Cast(ISO8601DateCaster)], whose unserialize() returns a DateTimeImmutable. The properties were typed ?string, so decoding threw a TypeError. Type them DateTimeInterface|string|null to match Common\DateTime::$date. Fixes chiiya/laravel-passes#41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes chiiya/laravel-passes#41.
Adding a
dateTime(EventDateTime) to anEventTicketClassand decoding it throws:Root cause
In
Google\Components\EventTicket\EventDateTime, thedoorsOpen,startandendproperties carry#[Cast(ISO8601DateCaster::class)], but were typed?string.DateCaster::unserialize()returns aDateTimeImmutable, which cannot be assigned to a?stringparameter duringdecode()— hence theTypeError.This is the inverse of the issue fixed in #51: there the caster returned
nullinto a non-nullable param; here it returns aDateTimeImmutableinto astringparam.Fix
Type the three date properties
DateTimeInterface|string|null, matchingCommon\DateTime::$date. The cast result now fits, andDateCaster::serialize()already handles bothDateTimeInterfaceand string inputs, so building/encoding is unaffected (round-trip still emits canonical ISO8601 strings).Tests
Added
tests/Google/Components/EventTicket/EventDateTimeTest.php:DateTimeImmutablevaluesFull suite passes (54 tests);
just lintclean.