Separate GreenPlum connection logic from PostgreSQL package#27
Draft
Copilot wants to merge 9 commits into
Draft
Conversation
…n logic Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor PG connection handling to reduce errors
Separate GreenPlum connection logic from PostgreSQL package
Feb 5, 2026
…iles Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
…tion support Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
…ackupHandler Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
Separate GreenPlum connection logic from PostgreSQL package
Separate GreenPlum connection logic from PostgreSQL to fix connection errors
Feb 5, 2026
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
Separate GreenPlum connection logic from PostgreSQL to fix connection errors
Separate GreenPlum and PostgreSQL connection logic
Feb 5, 2026
Copilot
AI
changed the title
Separate GreenPlum and PostgreSQL connection logic
Separate GreenPlum connection logic from PostgreSQL package
Feb 5, 2026
3633c51 to
81395bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL users see
pg_session_roleerrors whenpostgres.Connect()attempts GreenPlum-specific parameter fallbacks (gp_role,gp_session_role) that don't exist in vanilla PostgreSQL. GreenPlum segments fail to connect in utility mode during backup initialization.Changes
Extracted GreenPlum connection logic
greenplum/connect.gowith GP-specificConnect()that tries standard connection →gp_role=utility→gp_session_role=utilitytryConnectToGpSegment()frompostgres/connect.goConnect()instead ofpostgres.Connect()Implemented connection function injection
PgConnectFunctype alias for connection function signatureBackupArguments.connectFuncfield injectableNewBackupHandlerWithConnect()to accept custom connection during initializationGetPgServerInfo()to accept optional connection function (variadic for backward compatibility)Fixed segment backup initialization
NewSegBackupHandler()now injectsgreenplum.ConnectviaNewBackupHandlerWithConnect()GetPgServerInfo()callsPostgreSQL connections no longer attempt GreenPlum-specific fallbacks. GreenPlum functionality preserved with proper utility mode connection handling.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.