Fix race condition in binlog provider causing file-not-found errors#39
Draft
Copilot wants to merge 4 commits into
Draft
Fix race condition in binlog provider causing file-not-found errors#39Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
it seems govulncheck is broken after git release, let us comment it until resolved
…to ObjectProvider The issue was that provideLogs would add binlog files to the ObjectProvider before reading their timestamps. This created a race condition where the consumer goroutine (sendEventsFromBinlogFiles) could retrieve, parse, and delete the file before provideLogs attempted to read its timestamp, causing a "no such file or directory" error. Fixed by moving the timestamp reading before adding the file to the provider. Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MySQL base test failure
Fix race condition in binlog provider causing file-not-found errors
Feb 11, 2026
3633c51 to
81395bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Race condition in
provideLogswhere binlog files were added to ObjectProvider before reading their timestamps. Consumer goroutine (sendEventsFromBinlogFiles) could retrieve, parse, and delete files before timestamp reads completed.Changes:
provideLogsto readGetBinlogStartTimestampbeforep.AddObjectResolves
open /tmp/mysql-bin.XXXXXX: no such file or directoryerrors in mysql_base_tests.Original prompt
This section details on the original issue you should resolve
<issue_title>[FEATURE] address mysql base test failure</issue_title>
<issue_description>### What feature would you like?
we need to address the following failure