Add failover storage settings to SQL Server allowed config#41
Draft
Copilot wants to merge 4 commits into
Draft
Conversation
it seems govulncheck is broken after git release, let us comment it until resolved
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove warnings during SQL Server backup
Add failover storage settings to SQL Server allowed config
Feb 15, 2026
3633c51 to
81395bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL Server operations were emitting warnings for
WALG_FAILOVER_STORAGES_CACHE_LIFETIMEandWALG_FAILOVER_STORAGES_CHECK_TIMEOUTdespite these being valid failover storage settings already supported by PostgreSQL and Greenplum.Changes
SQLServerAllowedSettingsininternal/config/config.goThe settings include:
WALG_FAILOVER_STORAGESWALG_FAILOVER_STORAGES_CHECKWALG_FAILOVER_STORAGES_CHECK_TIMEOUTWALG_FAILOVER_STORAGES_CACHE_LIFETIMEWALG_FAILOVER_STORAGES_CACHE_EMA_*(6 EMA parameters)WALG_FAILOVER_STORAGES_CHECK_SIZEThis brings SQL Server to feature parity with other databases for failover storage configuration.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.