Skip to content

Add failover storage settings to SQL Server allowed config#41

Draft
Copilot wants to merge 4 commits into
masterfrom
copilot/cleanup-sql-server-warnings
Draft

Add failover storage settings to SQL Server allowed config#41
Copilot wants to merge 4 commits into
masterfrom
copilot/cleanup-sql-server-warnings

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 15, 2026

SQL Server operations were emitting warnings for WALG_FAILOVER_STORAGES_CACHE_LIFETIME and WALG_FAILOVER_STORAGES_CHECK_TIMEOUT despite these being valid failover storage settings already supported by PostgreSQL and Greenplum.

Changes

  • Added 11 failover storage configuration settings to SQLServerAllowedSettings in internal/config/config.go
  • Added test to verify settings are recognized for SQL Server configuration

The settings include:

  • WALG_FAILOVER_STORAGES
  • WALG_FAILOVER_STORAGES_CHECK
  • WALG_FAILOVER_STORAGES_CHECK_TIMEOUT
  • WALG_FAILOVER_STORAGES_CACHE_LIFETIME
  • WALG_FAILOVER_STORAGES_CACHE_EMA_* (6 EMA parameters)
  • WALG_FAILOVER_STORAGES_CHECK_SIZE

This brings SQL Server to feature parity with other databases for failover storage configuration.

Original prompt

This section details on the original issue you should resolve

<issue_title>[FEATURE] cleanup sql server warning</issue_title>
<issue_description>### What feature would you like?

when backup sql server, I see the following warnings. we need to remove them

C:\i\wal-bin>.\wal-g-sql.exe --config .\wal-g-sql.yaml delete retain FULL 3 --confirm
WARNING: 2026/02/15 12:17:21.587009 WALG_FAILOVER_STORAGES_CACHE_LIFETIME is unknown
WARNING: 2026/02/15 12:17:21.587639 WALG_FAILOVER_STORAGES_CHECK_TIMEOUT is unknown
WARNING: 2026/02/15 12:17:21.587639 We found that some variables in your config file detected as 'Unknown'.
  If this is not right, please create issue https://github.com/wal-g/wal-g/issues/new
INFO: 2026/02/15 12:17:21.589946 No backup found for deletion
PS C:\i\wal-bin>

Why is this feature useful?

No response</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

chipitsine and others added 2 commits February 10, 2026 17:07
it seems govulncheck is broken after git release, let us comment it
until resolved
Copilot AI and others added 2 commits February 15, 2026 11:22
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove warnings during SQL Server backup Add failover storage settings to SQL Server allowed config Feb 15, 2026
Copilot AI requested a review from chipitsine February 15, 2026 11:27
@chipitsine chipitsine force-pushed the master branch 2 times, most recently from 3633c51 to 81395bd Compare May 7, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] cleanup sql server warning

2 participants