Skip to content

Fix Docker image tag conflict in redis_combined_features target #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Fix Docker image tag conflict in redis_combined_features target #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fde0c2d
ci: pin govulncheck to the latest
chipitsine Feb 15, 2026
9a51c18
Initial plan
Copilot Feb 15, 2026
56ef623
Add redis_combined_features target to run AOF and RDB tests together
Copilot Feb 15, 2026
baaef71
Add comment explaining redis_combined_features target
Copilot Feb 15, 2026
554525d
Fix: Keep Redis 6.2.4 as RDB-only test due to AOF format incompatibility
Copilot Feb 15, 2026
020ea68
Add error handling to ensure cleanup on AOF test failure
Copilot Feb 15, 2026
bc3318a
Simplify error handling by removing redundant directory change
Copilot Feb 15, 2026
c697132
Fix cleanup command to run in correct directory
Copilot Feb 15, 2026
1c1b8e2
Add clarifying comment for cleanup behavior on test failure
Copilot Feb 15, 2026
aaccc5d
test
chipitsine Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 3 additions & 84 deletions .github/workflows/dockertests-par.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,96 +1,15 @@
name: Docker tests

on: [ push, pull_request, workflow_dispatch ]
on: [ pull_request, workflow_dispatch ]

jobs:
parallel:
uses: ./.github/workflows/dockertests.yml
with:
command-json-array: >
[
"make TEST=\"pg_ready_rename_test\" pg_integration_test",
"make TEST=\"pg_backup_mark_impermanent_test\" pg_integration_test",
"make TEST=\"pg_backup_mark_permanent_test\" pg_integration_test",
"make TEST=\"pg_config_test\" pg_integration_test",
"make TEST=\"pg_crypto_test\" pg_integration_test",
"make TEST=\"pg_copy_all_test\" pg_integration_test",
"make TEST=\"pg_copy_backup_test\" pg_integration_test",
"make TEST=\"pg_delta_backup_wal_delta_test\" pg_integration_test",
"make TEST=\"pg_full_backup_test\" pg_integration_test",
"make TEST=\"pg_full_backup_streamed_test\" pg_integration_test",
"make TEST=\"pg_partial_restore_test\" pg_integration_test",
"make TEST=\"pg_remote_backup_test\" pg_integration_test",
"make TEST=\"pg_remote_backup_without_files_metadata_test\" pg_integration_test",
"make TEST=\"pg_ssh_backup_test\" pg_integration_test",
"make TEST=\"pg_transfer_backup_test\" pg_integration_test",
"make TEST=\"pg_receive_wal_test\" pg_integration_test",
"make TEST=\"pg_full_backup_copy_composer_test\" pg_integration_test",
"make TEST=\"pg_full_backup_rating_composer_test\" pg_integration_test",
"make TEST=\"pg_full_backup_database_composer_test\" pg_integration_test",
"make TEST=\"pg_full_backup_failover_storage_test\" pg_integration_test",
"make TEST=\"pg_delete_before_name_find_full_test\" pg_integration_test",
"make TEST=\"pg_delete_before_permanent_delta_multist_test\" pg_integration_test",
"make TEST=\"pg_delete_before_permanent_delta_test\" pg_integration_test",
"make TEST=\"pg_delete_before_permanent_full_test\" pg_integration_test",
"make TEST=\"pg_delete_before_time_find_full_test\" pg_integration_test",
"make TEST=\"pg_delete_end_to_end_test\" pg_integration_test",
"make TEST=\"pg_delete_garbage_multist_test\" pg_integration_test",
"make TEST=\"pg_delete_garbage_test\" pg_integration_test",
"make TEST=\"pg_delete_retain_find_full_test\" pg_integration_test",
"make TEST=\"pg_delete_retain_full_multist_test\" pg_integration_test",
"make TEST=\"pg_delete_retain_full_test\" pg_integration_test",
"make TEST=\"pg_delete_retain_after_test\" pg_integration_test",
"make TEST=\"pg_delete_target_delta_find_full_test\" pg_integration_test",
"make TEST=\"pg_delete_target_delta_multist_test\" pg_integration_test",
"make TEST=\"pg_delete_target_delta_test\" pg_integration_test",
"make TEST=\"pg_delete_target_test\" pg_integration_test",
"make TEST=\"pg_delete_without_confirm_test\" pg_integration_test",
"make TEST=\"pg_delta_backup_fullscan_test\" pg_integration_test",
"make TEST=\"pg_ghost_table_test\" pg_integration_test",
"make TEST=\"pg_several_delta_backups_test\" pg_integration_test",
"make TEST=\"pg_several_delta_backups_reverse_test\" pg_integration_test",
"make TEST=\"pg_storage_swift_test\" pg_integration_test",
"make TEST=\"pg_storage_ssh_test\" pg_integration_test",
"make TEST=\"pg_wale_compatibility_test\" pg_integration_test",
"make TEST=\"pg_backup_mark_permanent_no_error_test\" pg_integration_test",
"make TEST=\"pg_daemon_test\" pg_integration_test",
"make TEST=\"pg_daemon_backup_and_restore_test\" pg_integration_test",
"make TEST=\"pg_daemon_client_test\" pg_integration_test",
"make TEST=\"prefetch_test\" pg_integration_test",
"make mongo_test",
"make MONGO_VERSION=\"8.0.3\" MONGO_REPO=\"repo.mongodb.org\" MONGO_PACKAGE=\"mongodb-org\" mongo_catch_up_features",
"make MONGO_VERSION=\"8.0.3\" MONGO_REPO=\"repo.mongodb.com\" MONGO_PACKAGE=\"mongodb-enterprise\" mongo_catch_up_features",
"make MONGO_VERSION=\"8.0.3\" MONGO_REPO=\"repo.mongodb.com\" MONGO_PACKAGE=\"mongodb-enterprise\" mongo_binary_features",
"make MONGO_VERSION=\"8.0.3\" MONGO_REPO=\"repo.mongodb.org\" MONGO_PACKAGE=\"mongodb-org\" mongo_logical_features",
"make MONGO_VERSION=\"8.0.3\" MONGO_REPO=\"repo.mongodb.com\" MONGO_PACKAGE=\"mongodb-enterprise\" mongo_partial_features",
"make MONGO_VERSION=\"7.0.15\" MONGO_REPO=\"repo.mongodb.org\" MONGO_PACKAGE=\"mongodb-org\" mongo_catch_up_features",
"make MONGO_VERSION=\"7.0.15\" MONGO_REPO=\"repo.mongodb.com\" MONGO_PACKAGE=\"mongodb-enterprise\" mongo_catch_up_features",
"make MONGO_VERSION=\"7.0.15\" MONGO_REPO=\"repo.mongodb.com\" MONGO_PACKAGE=\"mongodb-enterprise\" mongo_binary_features",
"make MONGO_VERSION=\"7.0.15\" MONGO_REPO=\"repo.mongodb.org\" MONGO_PACKAGE=\"mongodb-org\" mongo_logical_features",
"make MONGO_VERSION=\"7.0.15\" MONGO_REPO=\"repo.mongodb.com\" MONGO_PACKAGE=\"mongodb-enterprise\" mongo_partial_features",
"make redis_test",
"make FEATURE=\"aof_backup\" IMAGE_TYPE=\"aof\" REDIS_VERSION=\"7.0.15\" redis_features",
"make FEATURE=\"aof_backup\" IMAGE_TYPE=\"aof\" REDIS_VERSION=\"7.2.4\" redis_features",
"make FEATURE=\"rdb_backup\" IMAGE_TYPE=\"rdb\" REDIS_VERSION=\"6.2.4\" redis_features",
"make FEATURE=\"rdb_backup\" IMAGE_TYPE=\"rdb\" REDIS_VERSION=\"7.0.15\" redis_features",
"make FEATURE=\"rdb_backup\" IMAGE_TYPE=\"rdb\" REDIS_VERSION=\"7.2.4\" redis_features",
"make TEST=\"pg_wale_tablespace_compatibility_test\" pg_integration_test",
"make TEST=\"pg_tablespace_support_test\" pg_integration_test",
"make TEST=\"pg_walg_tablespace_restore_spec_test\" pg_integration_test",
"make TEST=\"pg_wal_perftest\" pg_integration_test",
"make TEST=\"pg_wal_perftest_with_throttling\" pg_integration_test",
"make TEST=\"pg_backup_perftest\" pg_integration_test",
"make TEST=\"pg_catchup_test\" pg_integration_test",
"make TEST=\"pg_wal_restore_test\" pg_integration_test",
"make MYSQL_TEST=mysql_base_tests mysql_integration_test",
"make MYSQL_TEST=mysql_delete_tests mysql_integration_test",
"make MYSQL_TEST=mysql_copy_tests mysql_integration_test",
"make USE_BROTLI= USE_LZO= USE_LIBSODIUM= MYSQL_TEST=mysql8_tests mysql8_integration_test",
"make mariadb_test",
"make gp_test",
"make cloudberry_test",
"make st_test",
"make TEST=\"pg_pgbackrest_backup_fetch_test\" pg_integration_test",
"make etcd_test",
"make orioledb_integration_test",
"make REDIS_VERSION=\"7.0.15\" redis_combined_features",
"make REDIS_VERSION=\"7.2.4\" redis_combined_features",
]
25 changes: 0 additions & 25 deletions .github/workflows/golangci-lint.yml
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions .github/workflows/golvulncheck.yml
View file
Open in desktop

This file was deleted.

102 changes: 0 additions & 102 deletions .github/workflows/release.yml
View file
Open in desktop

This file was deleted.

39 changes: 0 additions & 39 deletions .github/workflows/unittests.yml
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions .github/workflows/windows-native.yml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,15 @@ clean_redis_features:
set -e
cd tests_func/ && REDIS_VERSION=$(REDIS_VERSION) go test -v -count=1 -timeout 5m --tf.test=false --tf.debug=false --tf.clean=true --tf.stop=true --tf.database=redis

# Run both AOF and RDB tests sequentially to save infrastructure setup time
# Note: If AOF test fails, cleanup runs with --tf.test=false to only clean up (no tests)
redis_combined_features:
set -e
make go_deps
cd tests_func/ && REDIS_VERSION=$(REDIS_VERSION) IMAGE_TYPE=aof FEATURE=aof_backup go test -v -count=1 -timeout 20m --tf.test=true --tf.debug=false --tf.clean=false --tf.stop=false --tf.database=redis || \
(cd tests_func/ && REDIS_VERSION=$(REDIS_VERSION) go test -v -count=1 -timeout 5m --tf.test=false --tf.debug=false --tf.clean=true --tf.stop=true --tf.database=redis; exit 1)
cd tests_func/ && REDIS_VERSION=$(REDIS_VERSION) IMAGE_TYPE=rdb FEATURE=rdb_backup go test -v -count=1 -timeout 20m --tf.test=true --tf.debug=false --tf.clean=true --tf.stop=true --tf.database=redis

etcd_test: deps etcd_build unlink_brotli etcd_integration_test

etcd_build: $(CMD_FILES) $(PKG_FILES)
Expand Down
Loading