Fix pg_receive_wal_test race condition and handle postgres shutdown NoticeResponse#47
Draft
Copilot wants to merge 7 commits into
Draft
Fix pg_receive_wal_test race condition and handle postgres shutdown NoticeResponse#47Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
it has issues with checkout fixed in current master
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace brotli dependency with pure Go implementation
Replace CGO brotli dependency with pure Go implementation
Feb 26, 2026
Copilot stopped work on behalf of
chipitsine due to an error
February 26, 2026 09:01
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
Replace CGO brotli dependency with pure Go implementation
Remove obsolete brotli CGo sed patch from pg_tests Dockerfile
Feb 26, 2026
Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
Remove obsolete brotli CGo sed patch from pg_tests Dockerfile
Remove obsolete brotli CGo sed patches from Dockerfiles
Feb 26, 2026
…ceResponse gracefully Co-authored-by: chipitsine <2217296+chipitsine@users.noreply.github.com>
Copilot
AI
changed the title
Remove obsolete brotli CGo sed patches from Dockerfiles
Fix pg_receive_wal_test race condition and handle postgres shutdown NoticeResponse
Feb 26, 2026
3633c51 to
81395bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wal-verify integritywas running whilewal-receivewas still actively streaming, causing segments to appear asMISSING_UPLOADING(→WARNING) instead ofFOUND(→OK). Additionally,wal-receivewould crash with "Received unexpected message" when postgres sent aNoticeResponseon shutdown.Changes
docker/pg_tests/scripts/tests/test_functions/test_receive_wal.sh-m fastbefore runningwal-verify, so all WAL has been generated before checkingwaitfor it to finish uploading remaining segments before verifyingsleep 1internal/databases/postgres/wal_segment.go*pgproto3.NoticeResponsecase toprocessMessage(): log it as a warning and returnOKinstead of treating it as a fatal unexpected message. Postgres sends this notice before closing a replication connection on clean shutdown.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.