Skip to content

Clack renderer feature#1390

Draft
justin-thurman wants to merge 21 commits into
mainfrom
clack-renderer-feature
Draft

Clack renderer feature#1390
justin-thurman wants to merge 21 commits into
mainfrom
clack-renderer-feature

Conversation

@justin-thurman

@justin-thurman justin-thurman commented Jun 10, 2026

Copy link
Copy Markdown
Contributor
📦 Published PR as canary version: 17.5.0--canary.1390.27278495931.0

✨ Test out this PR locally via:

npm install chromatic@17.5.0--canary.1390.27278495931.0
# or 
yarn add chromatic@17.5.0--canary.1390.27278495931.0

justin-thurman and others added 21 commits June 2, 2026 10:29
Implement Clack-based task rendering and tracer bullet the `auth` task
Implement `broadcastRenderer` to fan out multiple `TaskRenderer`s
Fan out `auth` and `intro` output to Clack and file logging
Adds an optional output?: Writable seam to clackTaskLogRenderer, the
intro/log wrappers, and renderer/index.ts intro, defaulting to
process.stdout so runtime behavior is unchanged. Enables the Storybook
capture harness to redirect Clack output to an in-memory sink.
settle.ts collapses a captured live-terminal stream into its final
frame; captureTask.ts drives the real renderer/index.ts intro and
clackTaskLogRenderer against an in-memory TTY sink and returns the
settled ANSI, with a scoped CI reset (forcing TTY rendering) and pinned
80-col width. fixtures.ts holds the shared env/options/pkg.

Tests cover settle's erase-block collapse and passthrough invariants,
plus the two things Chromatic's pixel diff can't see: OSC 8 hyperlink
structure and CI parity.
Implement Clack-based storybook rendering
@github-actions

Copy link
Copy Markdown
Contributor

📦 Package Size: 7144 KB

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.42857% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.41%. Comparing base (157cd37) to head (73e4956).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
node-src/renderer/engine/index.ts 78.04% 8 Missing and 1 partial ⚠️
node-src/renderer/storybook/captureTask.ts 75.67% 9 Missing ⚠️
node-src/renderer/engine/clack/wrap.ts 94.66% 4 Missing ⚠️
node-src/renderer/storybook/settle.ts 98.38% 1 Missing ⚠️
node-src/tasks/auth.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
+ Coverage   81.22%   82.41%   +1.19%     
==========================================
  Files         228      243      +15     
  Lines        4287     4624     +337     
  Branches     1229     1310      +81     
==========================================
+ Hits         3482     3811     +329     
- Misses        692      700       +8     
  Partials      113      113              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant