Migrate storybookInfo to Clack#1392
Open
justin-thurman wants to merge 5 commits into
Open
Conversation
Contributor
|
📦 Package Size: 7132 KB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## CAP-4584 #1392 +/- ##
============================================
+ Coverage 81.90% 81.91% +0.01%
============================================
Files 242 243 +1
Lines 4565 4568 +3
Branches 1293 1294 +1
============================================
+ Hits 3739 3742 +3
Misses 713 713
Partials 113 113 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ff1ba5b to
26b7f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
storybookInfotask to Clack and updates the relevant stories. In addition to the boilerplate part of the migration, there are three other changes:runTaskto bail early whenctx.skipis set (which can be set upstream bygitInfo).storybookInfotask. Our current storybook only tests pending/success.Manual QA
Staging app used for QA:
Build 1: happy path
Note the build number is 2. I forgot to use

--log-filefor the first build.Log file head:
Build 2: skipping a rebuild
Ran again on the same commit without

--force-rebuild.gitInfoset skip, sostorybookInfodoesn't render at all.Note this UI is kind of strange, as the remaining Listr tasks still render in a skipped state, but the Storybook info task is just missing. This UI will be cleaner when the migration is complete, as the
Skipping buildline will be terminal.Log file head:
Build 3: non-interactive renderer

Build 4: failure state
I deleted the

build-storybookscript from mypackage.json, which causes this task to fail.Full log file:
Note that the log file does include the detailed error output in the task failure log, because only the Clack renderer (not the log renderer) was updated to remove it.
📦 Published PR as canary version:
17.4.2--canary.1392.27418016999.0✨ Test out this PR locally via:
npm install chromatic@17.4.2--canary.1392.27418016999.0 # or yarn add chromatic@17.4.2--canary.1392.27418016999.0