enhance: make query view fanout target configurable - #86
Merged
Merged
Conversation
Add a refreshable QueryCoord setting for the target number of rows per shard node. Read the latest value when building each balancer snapshot so subsequent reconciliation cycles use the updated fanout budget. Signed-off-by: sijie-ni-0214 <sijie.ni@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Add a refreshable QueryCoord setting for the target number of rows per shard node. The balancer reads the latest value when building each snapshot so later reconciliation cycles use the updated fanout budget.
Cherry-picked from
d00d27c537dacc780185d2b04bec84b198f4f3f8and adapted to preserve theqvbranch's existing full-reconciliation configuration semantics.Related PR: sunby#21
Test Plan
git diff --checkgo test -tags dynamic,test -gcflags="all=-N -l" -count=1 ./util/paramtable -run '^TestComponentParam_QueryViewTargetRowsPerShardNode$'