Conversation
c227dbf to
69543f0
Compare
|
View your CI Pipeline Execution ↗ for commit 69543f0 ☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should reduce cross-project source typechecking by switching selected targets to package-mode builds.
easy win for build times, but the annotations spike changed a few details of the approach.
new findings from the annotations spike
buildLibsFromSource: falseis still the right switch for stopping cross-library source typechecks.nx.json(targetDefaults.build.dependsOn: ["^build"]andtargetDefaults["@nx/vite:build"].dependsOn: ["^build"]) still forces transitive dependency builds. if a target should really build itself only, it must override that withdependsOn: [].@carma-commons/utils/*are the main friction point. Nx rewrites those nested paths to exact extensionless dist targets, so tsconfig aliases alone are not enough. the built package surface has to match that shape.commons/utilsneeded secondary entrypoint outputs forpromise,window,number-format, andfetching, andcesium-legacyneeded a declaration-surface fix so its built API matches its source barrel.dependsOn: [], changed dependencies are not rebuilt automatically. that is intentional for isolated library builds, but app/playground targets either need fresh dependency outputs or they should keep dependency orchestration.verified in the annotations spike
nx run annotations-core:buildnx run annotations-runtime:buildnx run annotations-builtin-tools:buildnx run annotations:build:productionafter rebuilding touched dependency outputsexternal prerequisites / follow-ups
@carma/mathalias as part of #588@carma-commons/utils/*nesting via #625 as follow-up cleanup, not a hard blocker for annotations package-mode builds