Fix exception on Bad argument#3925
Open
lLukDreams wants to merge 1 commit into
Open
Conversation
FabianTerhorst
approved these changes
Apr 28, 2026
Contributor
FabianTerhorst
left a comment
There was a problem hiding this comment.
Thanks for the contribution 👍
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal of this PR
Improve the robustness and security of event argument handling by preventing malformed or malicious arguments from disrupting server functionality.
How is this PR achieving the goal
This PR strengthens argument conversion and error handling within the event handler system:
ChangeTypemethod to safely handleInvalidCastException,FormatException, andOverflowException, preventing crashes or unintended behavior caused by invalid input.GetPassArgumentsto optionally accept aneventName, allowing error messages to include contextual information for better debugging.This PR applies to the following area(s)
Successfully tested on
Game builds: Latest
Platforms: Windows
Checklist