fix(citizen-server-impl): scan categories with lexically relative path#3967
Open
D4isDAVID wants to merge 1 commit into
Open
fix(citizen-server-impl): scan categories with lexically relative path#3967D4isDAVID wants to merge 1 commit into
D4isDAVID wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Currently,
ensureing categories will not start any resources that are a symlink.How is this PR achieving the goal
Instead of computing the relative path to the absolute directory, use
lexically_relativewithout computing the symlink. This means the path that will be scanned for categories would always be inside the resources root.This PR applies to the following area(s)
Server
Successfully tested on
Platforms: Windows
Checklist
Fixes issues