Skip to content

SharpClaw's Python WENO path silently only uses the slow reconstructor #758

Description

@mandli

clawpack.pyclaw.limiters.reconstruct — the wrapper around the compiled PyWENO reconstructor — cannot be imported at all, in a checkout or an install:

>>> import clawpack.pyclaw.limiters.reconstruct
ModuleNotFoundError: No module named 'pyclaw'

Its only import, src/pyclaw/limiters/reconstruct.py:12, is pre-namespace:

import pyclaw.limiters.weno.reconstruct as recon    # needs `clawpack.` prefix

At src/pyclaw/sharpclaw/solver.py:13-18 it catches this and falls back to the older version.

The C extension itself build and installs fine so it looked like a one-line fix, but according to claude (see below) this is insufficient.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugperformancesharpclawPertains the high-order WENO reconstruction algorithms in sharpclaw.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions