Skip to content

feat(layout-directed-graph): add disableOptimalOrderHeuristic and customOrder options#2942

Merged
kumilingus merged 4 commits into
clientIO:masterfrom
kumilingus:dagre-update
May 1, 2025
Merged

feat(layout-directed-graph): add disableOptimalOrderHeuristic and customOrder options#2942
kumilingus merged 4 commits into
clientIO:masterfrom
kumilingus:dagre-update

Conversation

@kumilingus
Copy link
Copy Markdown
Contributor

@kumilingus kumilingus commented Apr 24, 2025

Expose dagre options disableOptimalOrderHeuristic and customOrder through the DirectedGraph.layout() function.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new layout options—disableOptimalOrderHeuristic and customOrder—to the directed graph layout engine.

  • Adds a new test for the customOrder callback
  • Integrates the new options into the layout configuration within DirectedGraph.mjs

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
packages/joint-layout-directed-graph/test/index.js Added a QUnit test to validate the customOrder option functionality
packages/joint-layout-directed-graph/DirectedGraph.mjs Incorporated disableOptimalOrderHeuristic and customOrder options into the layout process
Files not reviewed (1)
  • packages/joint-layout-directed-graph/package.json: Language not supported
Comments suppressed due to low confidence (1)

packages/joint-layout-directed-graph/DirectedGraph.mjs:185

  • Consider adding a dedicated test case to verify the behavior of the disableOptimalOrderHeuristic option and ensure it influences layout as expected.
disableOptimalOrderHeuristic: !!opt.disableOptimalOrderHeuristic,

@kumilingus kumilingus marked this pull request as ready for review April 29, 2025 10:53
@kumilingus kumilingus merged commit 47a3f70 into clientIO:master May 1, 2025
3 checks passed
kumilingus added a commit that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants