Skip to content

Switch from using flake8 to using ruff#431

Open
fabi200123 wants to merge 2 commits into
cloudbase:masterfrom
fabi200123:switch-to-ruff
Open

Switch from using flake8 to using ruff#431
fabi200123 wants to merge 2 commits into
cloudbase:masterfrom
fabi200123:switch-to-ruff

Conversation

@fabi200123
Copy link
Copy Markdown
Contributor

Switch from using flake8 to using ruff, which also allows to auto-format the code.

Comment thread tox.ini
# E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301
#
# E501 (line too long) is left to ruff
# E203 (whitespace before ':') conflicts with how ruff formats slices.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about H301, H306?

Comment thread ruff.toml
[lint]
select = ["E", "W", "F"]

ignore = [
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add the explanations for these ignores too.

Comment thread tox.ini
# E125 is deliberately excluded. See https://github.com/jcrocholl/pep8/issues/126
# E251 Skipped due to https://github.com/jcrocholl/pep8/issues/301
#
# E501 (line too long) is left to ruff
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 is left to ruff, but E501 is ignored in ruff, as seen in ruff.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants