integration: Various test fixes and cleanup#440
Merged
petrutlucian94 merged 3 commits intoMay 26, 2026
Conversation
petrutlucian94
approved these changes
May 25, 2026
| """ | ||
| ctxt = self._get_db_context() | ||
| try: | ||
| deployment = db_api.get_deployment(ctxt, deployment_id) |
Member
There was a problem hiding this comment.
Mixing DB requests with Coriolis API requests feels a bit odd but I guess it's reasonable in this case.
claudiubelu
force-pushed
the
integration-tests-fixes
branch
from
0c89d41 to
79b3c52
Compare
- On transfer execution, we now cancel the execution before deleting it. - On deployments, we now cancel the deployment before deleting it. - Fix string formatting in wait_for_execution. - Add last state in wait_for_deployment failure.
- Refactor Importer / Exporter class references. They are now referenced through the harness. This will allow them to be swapped in the future. - Refactor Importer / Exporter connection info. - Correctly skip Import provider that does not support minion pools. This needs to be done earlier, so the minion pool isn't created on a provider that do not support them. - raise AssertionError instead of using cls.fail.
claudiubelu
force-pushed
the
integration-tests-fixes
branch
from
79b3c52 to
6d03dbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertionErrorinstead of usingcls.fail.README.mdfile with up-to-date information.