Allow filtering results by status#441
Merged
Merged
Conversation
claudiubelu
reviewed
May 26, 2026
| http_exc.BadRequest, | ||
| self._client.transfer_executions.list, | ||
| self._completed_transfer.id, | ||
| filters={"status": "fake-status"}) |
Member
There was a problem hiding this comment.
maybe also include a bad filter case?
Member
Author
There was a problem hiding this comment.
It turns out that the Coriolis API silently ignores unknown GET parameters, just like Nova did until a few years ago. Fixing it would require a larger change and it's outside the scope of this PR.
We're adding a "status" search option that can be specified when
listing the following resources:
* deployments
* status -> last_execution_status db field
* transfers
* transfer executions
The filtering will be performed on the db side.
petrutlucian94
force-pushed
the
state_filter
branch
from
3c5c06a to
a1ff48f
Compare
claudiubelu
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're adding a "status" search option that can be specified when listing the following resources:
The filtering will be performed on the db side.
Client PR: cloudbase/python-coriolisclient#100