Export SDK error classes from @cloudflare/sandbox root#518
Open
zllovesuki wants to merge 1 commit intocloudflare:mainfrom
Open
Export SDK error classes from @cloudflare/sandbox root#518zllovesuki wants to merge 1 commit intocloudflare:mainfrom
zllovesuki wants to merge 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6cc1995 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
📦 Preview BuildVersion: Install the SDK preview:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #517.
The published package already contains the SDK's concrete error classes internally, but the root
@cloudflare/sandboxentrypoint did not re-export many of them. That made exact error handling awkward for consumers becauseinstanceofchecks from the package root failed at import time.This PR makes the root package export the full existing SDK error-class surface, including:
SandboxErrorSessionAlreadyExistsErrorSessionDestroyedErrorProcessNotFoundErrorand the rest of the concrete SDK error classes already exposed by the internal errors barrel.
Changes
@cloudflare/sandboxResult
Consumers can now do:
Testing
npm run check still reports two existing Biome warnings in packages/sandbox-container tests, but the command completes successfully.