Remove HTTP/WebSocket transports in favor of capnweb#539
Draft
aron-cf wants to merge 1 commit intocapnweb-rpcfrom
Draft
Remove HTTP/WebSocket transports in favor of capnweb#539aron-cf wants to merge 1 commit intocapnweb-rpcfrom
aron-cf wants to merge 1 commit intocapnweb-rpcfrom
Conversation
Make capnweb the sole transport between the Sandbox DO and container. Remove the old SandboxClient, all HTTP domain clients, the transport abstraction layer, HTTP handlers, router, route setup, middleware, and the WebSocket adapter. The RPCSandboxClient (backed by ContainerConnection) is now the only client implementation. The container serves capnweb RPC at /capnweb and PTY WebSocket at /ws/pty, with a minimal /health endpoint. SANDBOX_TRANSPORT env var is no longer read — capnweb is always used.
|
commit: |
Contributor
🐳 Docker Images Published
Usage: FROM cloudflare/sandbox:0.0.0-pr-539-be3336fVersion: 📦 Standalone BinaryFor arbitrary Dockerfiles: COPY --from=cloudflare/sandbox:0.0.0-pr-539-be3336f /container-server/sandbox /sandbox
ENTRYPOINT ["/sandbox"]Download via GitHub CLI: gh run download 23743655363 -n sandbox-binaryExtract from Docker: docker run --rm cloudflare/sandbox:0.0.0-pr-539-be3336f cat /container-server/sandbox > sandbox && chmod +x sandbox |
Member
|
(I know this is wip, but I'm VERY EXCITED for this) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
DO NOT MERGE!
Make capnweb the sole transport between the Sandbox DO and container.
Remove the old SandboxClient, all HTTP domain clients, the transport
abstraction layer, HTTP handlers, router, route setup, middleware,
and the WebSocket adapter.
The RPCSandboxClient (backed by ContainerConnection) is now the only
client implementation. The container serves capnweb RPC at /capnweb
and PTY WebSocket at /ws/pty, with a minimal /health endpoint.
SANDBOX_TRANSPORT env var is no longer read — capnweb is always used.