-
Notifications
You must be signed in to change notification settings - Fork 355
fix(pages): preserve missing page props on errors #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,208
−174
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1f5abf4
fix(pages): preserve missing page props on errors
james-elicx 36ed1ff
fix(pages): complete default error props contract
james-elicx 8635f98
fix(pages): match default error component contract
james-elicx d863fe3
fix(pages): complete next error parity
james-elicx 438a17a
fix(pages): make next error subclassable
james-elicx de064d8
fix(pages): align next error context types
james-elicx af70356
fix(pages): isolate error context types
james-elicx 4ea7045
test(pages): cover default error production hydration
james-elicx 6002fcf
test(pages): cover default error hydration in dev
james-elicx 76fbeb9
fix(pages): hydrate dev error responses
james-elicx 02abf13
fix(pages): set dev error router context
james-elicx 5473cf5
fix(pages): isolate dev error router state
james-elicx b786df4
fix(pages): align dev error router hydration
james-elicx 02ce049
fix(pages): keep error router ready during hydration
james-elicx 4234482
fix(pages): clean up error fallback handling
james-elicx 8876103
Merge remote-tracking branch 'origin/main' into codex/fix-pages-no-pa…
james-elicx 67d074f
fix(pages): load custom error page on navigation
james-elicx 375d9d8
Merge remote-tracking branch 'origin/main' into codex/fix-pages-no-pa…
james-elicx 79074bf
refactor(pages): share dev hydration entry
james-elicx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.