Skip to content

Fix azurerm_storage_container config - #688

Merged
neddp merged 1 commit into
cloudfoundry:mainfrom
jochenehret:fix_azurerm_storage_container_config
Jul 31, 2026
Merged

Fix azurerm_storage_container config#688
neddp merged 1 commit into
cloudfoundry:mainfrom
jochenehret:fix_azurerm_storage_container_config

Conversation

@jochenehret

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5e5ff75b-9742-4bc5-80c6-fb68ab32ea21

📥 Commits

Reviewing files that changed from the base of the PR and between 955778a and 050af39.

📒 Files selected for processing (1)
  • terraform/azure/templates/storage.tf

Walkthrough

Updated the Azure BOSH and stemcell storage container resources to use storage_account_id with the BOSH storage account resource ID instead of storage_account_name. Container access settings remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing the azurerm_storage_container configuration.
Description check ✅ Passed The description is directly related to the change and mentions the Azure Terraform provider breaking change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 29, 2026
@beyhan
beyhan requested review from a team, mariash and mkocher and removed request for a team July 30, 2026 14:44
@beyhan beyhan moved this from Pending Merge | Prioritized to Pending Review | Discussion in Foundational Infrastructure Working Group Jul 30, 2026

@selzoc selzoc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just fixed up the Azure CPI yesterday cloudfoundry/bosh-azure-cpi-release#751

@github-project-automation github-project-automation Bot moved this from Pending Review | Discussion to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 30, 2026
@neddp
neddp merged commit 5e7f7e4 into cloudfoundry:main Jul 31, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants