Skip to content

Remove fog provider support - #671

Open
kathap wants to merge 11 commits into
developfrom
remove-fog-aws
Open

Remove fog provider support #671
kathap wants to merge 11 commits into
developfrom
remove-fog-aws

Conversation

@kathap

@kathap kathap commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Needs cloudfoundry/cloud_controller_ng#5288 to be in first.

Remove all fog references from job templates, specs and bpm config.

Complete fog removal follow-up for capi-release. All fog gems have been removed from cloud_controller_ng; this PR removes the remaining fog references from BOSH job templates and specs.

A short explanation of the proposed change:
Removes all remaining fog blobstore references from BOSH job templates, specs, and shared scripts following the fog gem removal from cloud_controller_ng.

An explanation of the use cases your change solves:
Fog blobstore support has been fully dropped. This PR ensures the BOSH release is consistent with that — no more fog properties, fog-specific nginx config, or fog+NFS setup logic. blobstore_type now defaults to storage-cli; operators using storage-cli must supply a blobstore_provider, which all cf-deployment-based environments already do.

Changes:

  • Remove fog_connection from all cloud_controller_ng.yml.erb templates and job specs (all 5 jobs: cloud_controller_ng, cloud_controller_worker, cloud_controller_clock, cc_deployment_updater, blobstore_benchmark)
  • Remove fog_aws_storage_options and fog_gcp_storage_options from job specs and templates
  • Remove cc.log_fog_requests BOSH property and FOG_DEBUG env var from bpm.yml.erb and job specs (cloud_controller_ng, cloud_controller_worker)
  • Remove legacy 'AWS' provider name from storage-cli config templates; only native 's3' is now accepted
  • Remove legacy 'webdav' provider alias from storage-cli config templates; only native 'dav' is now accepted
  • Update all storage-cli config specs to use native provider names (s3, dav) instead of legacy fog names
  • Delete local_blobstore_downloads.conf.erb and its nginx includes — was fog-local-provider nginx config, now dead code
  • Remove dead fog+NFS logic from setup_local_blobstore.sh.erb and blobstore_waiter.sh.erb
  • Update bpm_spec to remove fog debug logging tests
  • Update blobstore_type valid values to ['webdav', 'storage-cli'] and set the default to storage-cli (previously defaulted to the now-removed fog)
  • Update blobstore_provider description to note it is required when blobstore_type is storage-cli
  • Update blobstore_benchmark.mode to drop the removed fog option (default remains storage-cli)
  • Removed CDN config (cdn.uri/key_pair_id/private_key) from all blobstore sections and jobs — it depended on fog/CloudFront signing, which is being removed.

Behavior change: the default blobstore_type changes from the now-removed fog to storage-cli. Deployments that relied on the implicit fog default will now use storage-cli and must set blobstore_provider (and its connection config); without a provider, CC fails at startup with No provider specified in config file. All cf-deployment-based deployments are unaffected, as they already set blobstore_type and blobstore_provider explicitly.

@kathap kathap changed the title Remove fog-aws legacy provider support from storage-cli config and specs Remove fog provider support Jul 17, 2026
@kathap
kathap marked this pull request as ready for review July 17, 2026 08:37
Comment thread jobs/cloud_controller_clock/spec Outdated
Comment thread jobs/cloud_controller_ng/templates/local_blobstore_downloads.conf.erb Outdated
Comment thread jobs/cloud_controller_worker/spec Outdated
kathap added 2 commits July 29, 2026 13:02
- Drop 'fog' from valid values and remove default for all blobstore_type
properties across cloud_controller_ng, cloud_controller_clock, and
cloud_controller_worker specs; operators must now explicitly configure
blobstore_type (breaking change)
- Remove local_blobstore_downloads.conf.erb template and its nginx includes
- Remove dead fog+NFS logic from setup_local_blobstore.sh.erb and
blobstore_waiter.sh.erb
- Fix duplicate default on cc.db_logging_level in cloud_controller_worker spec
- Bump cloud_controller_ng submodule to include fog removal changes
Comment thread jobs/cloud_controller_clock/spec
jochenehret
jochenehret previously approved these changes Jul 29, 2026
stephanme
stephanme previously approved these changes Jul 30, 2026
@kathap
kathap marked this pull request as draft July 30, 2026 08:47
@kathap
kathap marked this pull request as ready for review July 30, 2026 09:34
@jochenehret

Copy link
Copy Markdown
Contributor

Tested on an AWS dev landscape, works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants