Skip to content

Add SHA-384 support to file checksum computation (FIPS+NCS) #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkalapov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add SHA-384 support to file checksum computation (FIPS+NCS) #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions util/digest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ func ComputeFileChecksum(filePath, algorithm string) (string, error) {
hasher = sha1.New()
case "SHA256":
hasher = sha256.New()
case "SHA384", "SHA-384":

@theghost5800 theghost5800 Jul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add support for sha3 algorithms?

hasher = sha512.New384()
case "SHA512":
hasher = sha512.New()
default:
Expand Down
9 changes: 9 additions & 0 deletions util/digest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,15 @@ var _ = Describe("Digest", func() {
})
})

Context("with SHA-384 algorithm name (as returned by deploy service for FIPS+NCS)", func() {
It("should compute the SHA-384 digest of the file", func() {
const testFileContent = "test file content"
os.WriteFile(testFile.Name(), []byte(testFileContent), 0644)
digest, err := util.ComputeFileChecksum(testFilePath, "SHA-384")
testutil.ExpectNoErrorAndResult(err, digest, "4b87814537ab46771af4f37f259d6321f8c36b9e0d9ed1eda10005031cf7de752b9937a9cfe02744a3fc9785c3106317")
})
})

AfterEach(func() {
testFile.Close()
os.Remove(testFileName)
Expand Down
Loading