Open
Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
This completes the removal of all MySQL v5.7 support from the release. Percona XtraDB Cluster v8.0 still depends on percona-xtrabackup v2.4 _binaries_ and will fail if they are not present. These old binaries are required _just in case_ the cluster upgrades from a Percona XtraDB Cluster v5.7 version. However, pxc-release explicitly rejects upgrades from old MySQL v5.7 data directories (this transtion should be completed under pxc/1.1.x versions) so percona-xtrabackup is no longer required. Since the Percona XtraDB Cluster v8.0 wsrep_sst_xtrabackup-v2 script requires the pxb-2.4/bin path to exist, the existing binaries are stubbed with a simple bash script that echos an expected version when the "pxb-2.4/bin/xtrabackup --version" option is passed and fails loudly otherwise. Removing provides two benefits: - Mitigate CVE scans against EOL software - Enable compilation support on ubuntu-resolute stemcells without patching GPLv2 Percona XtraBackup v2.4 source.
abg
force-pushed
the
feature/stub-percona-xtrabackup-24
branch
from
718fc2f to
ee2aff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes the removal of all MySQL v5.7 support from the release.
Percona XtraDB Cluster v8.0 still depends on percona-xtrabackup v2.4 binaries and will fail if they are not present.
These old binaries are required just in case the cluster upgrades from a Percona XtraDB Cluster v5.7 version. However, pxc-release explicitly rejects upgrades from old MySQL v5.7 data directories (this transtion should be completed under pxc/1.1.x versions) so percona-xtrabackup is no longer required.
Since the Percona XtraDB Cluster v8.0 wsrep_sst_xtrabackup-v2 script requires the pxb-2.4/bin path to exist, the existing binaries are stubbed with a simple bash script that echos an expected version when the "pxb-2.4/bin/xtrabackup --version" option is passed and fails loudly otherwise.
Removing Percona XtraBackup v2.4 provides two benefits: