-
Notifications
You must be signed in to change notification settings - Fork 6
chore: Bump vite from 6.4.1 to 6.4.2 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
868d0cb
6786044
9cf1705
0f0c435
c9f5a9a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,4 @@ build | |
| lib | ||
| /node_modules | ||
| coverage | ||
| test/tmp | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import fs from 'node:fs'; | ||
| import pathe from 'pathe'; | ||
|
|
||
| export function setup() { | ||
| const tmpDir = pathe.resolve('test/tmp'); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will run before starting a test to clean up temporary files. |
||
| fs.rmSync(tmpDir, { recursive: true, force: true }); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,4 +29,4 @@ test('should write documentation files into the outDir', async () => { | |
| classes: [expect.objectContaining({ name: 'TestUtilWrapper' })], | ||
| }); | ||
| expect(() => execSync('tsc dom.d.ts selectors.d.ts', { cwd: outDir, stdio: 'inherit' })).not.toThrow(); | ||
| }); | ||
| }, 20_000); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bumped timeout from the global 15 to 20s due to timeouts in github ci. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vite 6.4.2 blocks access to files outside the project root, which broke tests that write output to the OS temp. To fix this, we can either move the output directory into the project directory, or explicitly allowlist the temp path to restore the previous behavior. I prefer the first option, as it avoids broadening file system access unnecessarily and aligns with the principle of least privilege.