Skip to content

fix: add verbose logging on failures#14

Merged
cloudsmith-iduffy merged 2 commits into
masterfrom
iduffy/verbose-logging
Oct 10, 2025
Merged

fix: add verbose logging on failures#14
cloudsmith-iduffy merged 2 commits into
masterfrom
iduffy/verbose-logging

Conversation

@cloudsmith-iduffy
Copy link
Copy Markdown
Contributor

@cloudsmith-iduffy cloudsmith-iduffy commented Oct 8, 2025

When a failure occurs we don't always have enough information to figure out what happened, this PR aims to address that by exposing more information on a failure.

@colinmoynes colinmoynes marked this pull request as ready for review October 8, 2025 13:48
Copilot AI review requested due to automatic review settings October 8, 2025 13:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances error handling in the OIDC authentication system by adding verbose logging on failures. The changes provide detailed debugging information when authentication attempts fail, including JWT token details, HTTP response information, and error stack traces.

  • Added comprehensive error logging with JWT token decoding and detailed HTTP error information
  • Enhanced retry mechanism to include verbose logging on each failed attempt
  • Improved token validation error reporting with response body details

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

File Description
src/oidc-auth.js Added verbose error logging functions, enhanced retry mechanism with detailed error reporting, and improved token validation error handling
package.json Added prettier as a dev dependency for code formatting
.npmrc Added npm registry configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/oidc-auth.js Outdated
Comment thread src/oidc-auth.js
@cloudsmith-iduffy cloudsmith-iduffy merged commit e76d0bd into master Oct 10, 2025
13 checks passed
@cloudsmith-iduffy cloudsmith-iduffy deleted the iduffy/verbose-logging branch October 10, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants