fix(schema): truncate by rune in truncateString to avoid splitting UTF-8 - #1117
Open
feizhuzheng wants to merge 1 commit into
Open
fix(schema): truncate by rune in truncateString to avoid splitting UTF-8#1117feizhuzheng wants to merge 1 commit into
feizhuzheng wants to merge 1 commit into
Conversation
truncateString is documented to truncate to maxLen characters, but it used len(s) and s[:maxLen], which count and slice by byte. For multi-byte UTF-8 input (e.g. CJK or emoji) this could cut a character in half and produce invalid UTF-8. Count and slice by rune instead, consistent with truncateTextByChars and truncateSkillContent in the same module. Added a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
Check the PR title.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
truncateStringsays it "truncates a string to maxLen characters", but it useslen(s)ands[:maxLen], which count and slice by byte. For multi-byte UTF-8 input (CJK, emoji, ...) this can cut a rune in half and emit invalid UTF-8.This counts and slices by rune instead, so
maxLenreally means characters and the output is always valid UTF-8. It now matches howtruncateTextByCharsandtruncateSkillContentalready handle truncation in this repo. A non-positivemaxLenis also handled without panicking. AddedTestTruncateString.(Optional) Which issue(s) this PR fixes: