Skip to content

Auto rdf#26

Merged
erjank merged 21 commits into
mainfrom
autoRDF
Jun 16, 2026
Merged

Auto rdf#26
erjank merged 21 commits into
mainfrom
autoRDF

Conversation

@erjank

@erjank erjank commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Automate RDF calculation, output first nonzero bin.

@erjank erjank requested a review from StephMcCallum June 11, 2026 00:26
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@erjank erjank mentioned this pull request Jun 11, 2026
@erjank erjank requested a review from ced4rtree June 11, 2026 13:59
max_header_len=None,
)

rdf_action = hoomd.write.CustomWriter(action=rdf_calc, trigger=log_trigger)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the RDF writer triggers with the same frequency as the logger. Right now this is overkill because we presently only care about the last RDF. However, if we take the logic in 1-bead-spring-dpd of getting the first nonzero bin:
b = (rdf_data[:,1] !=0).argmax()
print("First nozero RDF value:", rdf_data[b])
we might consider using this in our stop criteria, in which case having logger- or gsd_logger triggers would be appropriate. Like if we make sure our energy is under the cutoff AND the closest interparticle spacing is greater than, say, 0.9.

@erjank

erjank commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, we might use similar real-time-logging of energies for our stop criteria, rather than depending on reading in a text file.

@erjank

erjank commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Hey mister, you gotta clean up the function docstrings before you merge this.

@erjank erjank merged commit 4b3d6e8 into main Jun 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant