Updating SiPM mapping for 30 degree sectors#5
Conversation
|
A new Pull Request was created by @kerstinlovisa for branch main. @Dr15Jones, @Moanwar, @akritkbehera, @bsunanda, @civanch, @cmsbuild, @iarspider, @kpedro88, @makortel, @mdhildreth, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test |
|
Note for reviewers: like for #2 this PR was long expected, to have the final mapping of the SiPM-on-tile compartment of HGCal which is needed for cassette assembly @ FNAL |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a43837/47271/summary.html Comparison SummarySummary:
|
|
Hi all, @smuzaffar, is anything needed for this PR, or can it be merged, please? Sorry to push, but we need it for PR cms-sw/cmssw#48571 in time for the cassette testing in September. |
|
Hi @smuzaffar, is anything needed for this PR, or can it be merged, please? |
|
+Upgrade |
|
@IzaakWN , I do not see any ref to this data file in cms-sw/cmssw#48571 so I do not understand how cmssw PR depends on it? From the externals point of view, I am no objections on signing it but want to make sure that we add data file which is really used. |
|
+externals ah I see that file is references here https://github.com/cms-sw/cmssw/blob/master/Geometry/HGCalMapping/python/hgcalmapping_cff.py#L6 |
|
+1 |
Updated SiPM channel map for channels on tileboards mapped in a complete 10 degree sector, including new typecodes.
Updated channel mapping of the SiPM tileboards, with:
The new channel mapping logic was presented during the DPG session of the last HGCal Workshop here.
This PR is made together with another PR to cmssw: 48571
Validation of known input pixel arts was done 2 times, first with a known issue in the input (making the output misspelled with correct mapping):


Secondly with fixed error in the input and more variation in ADC input values for even better validation:
(Note that rotation of SiPM tileboards is not yet implemented in DQM)
@pfs @jniedzie @jalimena