Skip to content

Upload results first, then update commit status; make process_pr fail… #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smuzaffar merged 2 commits into from
Aug 5, 2025
Merged

Upload results first, then update commit status; make process_pr fail… #2544

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f477cb
Upload results first, then update commit status; make process_pr fail…
iarspider Aug 5, 2025
c55eee1
Update pr_testing/test_multiple_prs.sh
iarspider Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pr_testing/test_multiple_prs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,7 +1392,8 @@ if ${ALL_OK} ; then
if [ "${BUILD_LOG_RES}" = "ERROR" ] ; then
echo "Found compilation warnings" >> ${RESULTS_DIR}/10-report.res
fi
mark_commit_status_all_prs '' 'success' -u "${PR_RESULT_URL}" -d "Passed"
REPORT_STATUS="success"
REPORT_TEXT="Passed"
else
TESTS_FAILED=""
if [ "X$BUILD_OK" = Xfalse ] ; then TESTS_FAILED="$TESTS_FAILED Build" ; fi
Expand All @@ -1410,7 +1411,8 @@ else
if [ "X$PYTHON3_BUILD_OK" = Xfalse ]; then
$CMS_BOT_DIR/report-pull-request-results PYTHON3_FAIL -f $WORKSPACE/python3.log ${REPORT_GEN_OPTS}
fi
mark_commit_status_all_prs '' 'error' -u "${PR_RESULT_URL}" -d "Failed: ${TESTS_FAILED}"
REPORT_STATUS="error"
REPORT_TEXT="Failed: ${TESTS_FAILED}"
fi
if [ -e ${RESULTS_DIR}/static.txt ]; then
if [ $(grep ${RESULTS_DIR}/static.txt -e 'EDM_ML_DEBUG_CHECKS;OK' | wc -l) -eq 0 ]; then
Expand All @@ -1428,6 +1430,7 @@ pushd $WORKSPACE
popd

prepare_upload_results
mark_commit_status_all_prs '' $REPORT_STATUS -u "${PR_RESULT_URL}" -d ${REPORT_TEXT}
Comment thread
iarspider marked this conversation as resolved.
Outdated
rm -rf $WORKSPACE/upload

echo "PR_BUILD_BASE=${WORKSPACE}" > $WORKSPACE/deploy-cmssw
Expand Down
10 changes: 4 additions & 6 deletions process_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2244,13 +2244,11 @@ def process_pr(
res = "-1"
res = "%s\n\n%s" % (res, o)
cmt = issue.create_comment(res)
logger.debug("Comment created: %s", cmt.html_url)
logger.debug("PR Result Comment created: %s", cmt.html_url)
else:
logger.warning(
"Not posting PR result comment: dryRun=%s, bool(o)=%s",
dryRun,
bool(o),
)
if not o:
logger.error("Server returned empty PR result")
exit(1)
if not dryRun:
last_commit_obj.create_status(
"success",
Expand Down